Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email )
Change subject: fix --disable-log-macros ...................................................................... Patch Set 3: Code-Review-1 (1 comment) File configure.ac: https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/4407d77b_42702981?usp=email : PS3, Line 511: if @[email protected] is correct here: it's the if-statement that needs to be fixed. ```suggestion if test x"$log_macros" == x"no" ``` In addition to that, I suggest to rename `ENABLE_LIBOSMOCORE_NO_LOGGING_DEFAULT` to `ENABLE_LOG_MACROS_DEFAULT` and assign `"yes"` by default. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab Gerrit-Change-Number: 42203 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 16:55:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
