Patch Set 6: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/6663/6/src/gsm/gsm23003.c File src/gsm/gsm23003.c: Line 233: if (mnc_3_digits) I can understand the f(mnc_3_digits) as the caller might not be interested in that. But do you thin that mnc=NULL is a valid API use of this function? I think it might be better to OSMO_ASSERT() in that case or at least to return an error code. Basically you can all the function with mnc=NULL by accident and it will still successfulyl return, which sounds a bit dangerous to me. what do you think? -- To view, visit https://gerrit.osmocom.org/6663 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6 Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
