Patch Set 6: (1 comment)
https://gerrit.osmocom.org/#/c/6663/6/src/gsm/gsm23003.c File src/gsm/gsm23003.c: Line 233: if (mnc_3_digits) > I can understand the f(mnc_3_digits) as the caller might not be interested a user of this is CTRL interface verification, which is not interested in the values, just whether it can be decoded properly, and passes only NULL args: https://gerrit.osmocom.org/#/c/6668/3/src/libbsc/bsc_ctrl_commands.c line 80 If you think this should not be allowed, that caller can of course let the values be decoded into unused local vars instead, let me know how you decide. -- To view, visit https://gerrit.osmocom.org/6663 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6 Gerrit-PatchSet: 6 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
