Patch Set 2: Code-Review+1 (3 comments)
The ToA computation logic looks a bit complicated in scheduler_trx.c. Somewhere we calculate AVG, but for FACCH we don't. Somewhere we multiply by 4, somewhere we divide by 256. Are you sure that everything is correct? I think it would be great to clarify and/or define macros for such computations? https://gerrit.osmocom.org/#/c/6955/2/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: Line 745: toa *= 10; Should this part also be updated? And does anyone still use it? Line 1060: n_errors, n_bits_total, rssi, toa256); Just wondering, why don't we compute the AVG here? https://gerrit.osmocom.org/#/c/6955/2/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: Line 523: int16_t toa256 = 0; No need to init, it will be overwritten. -- To view, visit https://gerrit.osmocom.org/6955 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idce4178e0b1f7e940ebc22b3e2f340fcd544d4ec Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
