Patch Set 2: (3 comments)
https://gerrit.osmocom.org/#/c/6955/2/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: Line 745: toa *= 10; > Should this part also be updated? I thikn it can be removed. For my patch, I will change it to toa256 *= 10 to not mix the two unrelated issues of changing float->int and the removal of this debugging (which can now be done much better with fake-trx. Line 1060: n_errors, n_bits_total, rssi, toa256); > Just wondering, why don't we compute the AVG here? you mean the average over all 4 bursts? I have no idea why not. My patch simply changes float->int, and doesn't intend to change any logic. FEel free to create a patch or ticket for averaging. https://gerrit.osmocom.org/#/c/6955/2/src/osmo-bts-trx/trx_if.c File src/osmo-bts-trx/trx_if.c: Line 523: int16_t toa256 = 0; > No need to init, it will be overwritten. once again, I'm just changing the data type here and try to not make any other modifications. -- To view, visit https://gerrit.osmocom.org/6955 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idce4178e0b1f7e940ebc22b3e2f340fcd544d4ec Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
