Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#11).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell identifier lists. The new parsing routines are based on similar
routines used by the paging code in osmo-bsc's osmo_bsc_bssap.c.
Likewise, introduce gsm0808_enc_cell_id_list2() with support for the
same additional types of cell identifier lists.
The old API using struct gsm0808_cell_id_list is deprecated.
The previous definition was insufficient because it assumed that all
decoded cell ID types could be represented with a single uint16_t.
It was declared in a GSM protocol header (gsm/protocol/gsm_08_08.h)
despite being a host-side representation of data in an IE.
The only user I am aware of is in osmo-msc, where this struct is used
for one local variable. osmo-msc releases >= 1.1.0 make use of this API.
Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Related: OS#2847
---
M include/osmocom/gsm/gsm0808.h
M include/osmocom/gsm/gsm0808_utils.h
M include/osmocom/gsm/gsm23003.h
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
M src/gsm/gsm0808_utils.c
M src/gsm/libosmogsm.map
M tests/gsm0808/gsm0808_test.c
8 files changed, 353 insertions(+), 31 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/6509/11
diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h
index 3deee70..62ff06e 100644
--- a/include/osmocom/gsm/gsm0808.h
+++ b/include/osmocom/gsm/gsm0808.h
@@ -28,6 +28,8 @@
struct sockaddr_storage;
struct msgb;
+struct gsm0808_cell_id_list;
+struct gsm0808_cell_id_list2;
struct msgb *gsm0808_create_layer3(struct msgb *msg_l3, uint16_t nc,
uint16_t cc, int lac, uint16_t _ci);
@@ -66,6 +68,10 @@
*scl);
struct msgb *gsm0808_create_assignment_failure(uint8_t cause, uint8_t
*rr_cause);
struct msgb *gsm0808_create_clear_rqst(uint8_t cause);
+struct msgb *gsm0808_create_paging2(const char *imsi, const uint32_t *tmsi,
+ const struct gsm0808_cell_id_list2 *cil,
+ const uint8_t *chan_needed);
+/* deprecated */
struct msgb *gsm0808_create_paging(const char *imsi, const uint32_t *tmsi,
const struct gsm0808_cell_id_list *cil,
const uint8_t *chan_needed);
diff --git a/include/osmocom/gsm/gsm0808_utils.h
b/include/osmocom/gsm/gsm0808_utils.h
index 7432164..f0b27bd 100644
--- a/include/osmocom/gsm/gsm0808_utils.h
+++ b/include/osmocom/gsm/gsm0808_utils.h
@@ -26,6 +26,27 @@
struct sockaddr_storage;
#include <osmocom/gsm/protocol/gsm_08_08.h>
+#include <osmocom/gsm/gsm23003.h>
+
+ /*! (225-1)/2 is the maximum number of elements in a cell identifier list. */
+#define GSM0808_CELL_ID_LIST2_MAXLEN 127
+
+/*! Parsed representation of a cell identifier list IE. */
+struct gsm0808_cell_id_list2 {
+ enum CELL_IDENT id_discr;
+ union {
+ /*!
+ * All elements of these arrays contain parsed representations
of the
+ * data in the corresponding IE, in host-byte order.
+ */
+ struct osmo_cell_global_id id_list_global;
+ struct osmo_lac_and_ci_id id_list_lac_and_ci;
+ uint16_t id_list_ci;
+ struct osmo_location_area_id id_list_lai_and_lac;
+ uint16_t id_list_lac;
+ } id_list[GSM0808_CELL_ID_LIST2_MAXLEN];
+ unsigned int id_list_len;
+};
uint8_t gsm0808_enc_aoip_trasp_addr(struct msgb *msg,
const struct sockaddr_storage *ss);
@@ -48,8 +69,12 @@
const struct gsm0808_encrypt_info *ei);
int gsm0808_dec_encrypt_info(struct gsm0808_encrypt_info *ei,
const uint8_t *elem, uint8_t len);
+uint8_t gsm0808_enc_cell_id_list2(struct msgb *msg, const struct
gsm0808_cell_id_list2 *cil);
+/* deprecated */
uint8_t gsm0808_enc_cell_id_list(struct msgb *msg,
const struct gsm0808_cell_id_list *cil);
+int gsm0808_dec_cell_id_list2(struct gsm0808_cell_id_list2 *cil, const uint8_t
*elem, uint8_t len);
+/* deprecated */
int gsm0808_dec_cell_id_list(struct gsm0808_cell_id_list *cil,
const uint8_t *elem, uint8_t len);
int gsm0808_chan_type_to_speech_codec(uint8_t perm_spch);
diff --git a/include/osmocom/gsm/gsm23003.h b/include/osmocom/gsm/gsm23003.h
index dd41bc5..9623a05 100644
--- a/include/osmocom/gsm/gsm23003.h
+++ b/include/osmocom/gsm/gsm23003.h
@@ -29,6 +29,13 @@
uint16_t cell_identity;
};
+/* Actually defined in 3GPP TS 48.008 3.2.2.27 Cell Identifier List,
+ * but conceptually belongs with the above structures. */
+struct osmo_lac_and_ci_id {
+ uint16_t lac;
+ uint16_t ci;
+};
+
/* 12.5 */
struct osmo_service_area_id {
struct osmo_location_area_id lai;
diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h
b/include/osmocom/gsm/protocol/gsm_08_08.h
index ba347ef..947f90f 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -501,8 +501,13 @@
unsigned int key_len;
};
-/* 3GPP TS 48.008 3.2.2.27 Cell Identifier List */
#define CELL_ID_LIST_LAC_MAXLEN 127
+/*!
+ * DEPRECATED: This definition of the cell identifier list is
+ * insufficient. It cannot support all types of cell identifiers.
+ * Use struct gsm0808_cell_id_list2 in gsm0808_utils.h instead.
+ *
+ * 3GPP TS 48.008 3.2.2.27 Cell Identifier List */
struct gsm0808_cell_id_list {
uint8_t id_discr;
uint16_t id_list_lac[CELL_ID_LIST_LAC_MAXLEN];
diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index c0be374..28f357f 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -497,16 +497,16 @@
* \param[in] cil Cell Identity List (where to page)
* \param[in] chan_needed Channel Type needed
* \returns callee-allocated msgb with BSSMAP PAGING message */
-struct msgb *gsm0808_create_paging(const char *imsi, const uint32_t *tmsi,
- const struct gsm0808_cell_id_list *cil,
- const uint8_t *chan_needed)
+struct msgb *gsm0808_create_paging2(const char *imsi, const uint32_t *tmsi,
+ const struct gsm0808_cell_id_list2 *cil,
+ const uint8_t *chan_needed)
{
struct msgb *msg;
uint8_t mid_buf[GSM48_MI_SIZE + 2];
int mid_len;
uint32_t tmsi_sw;
- /* Mandatory emelents! */
+ /* Mandatory elements! */
OSMO_ASSERT(imsi);
OSMO_ASSERT(cil);
@@ -534,7 +534,7 @@
/* Cell Identifier List 3.2.2.27 */
if (cil)
- gsm0808_enc_cell_id_list(msg, cil);
+ gsm0808_enc_cell_id_list2(msg, cil);
/* Channel Needed 3.2.2.36 */
if (chan_needed) {
@@ -549,6 +549,32 @@
return msg;
}
+/*! DEPRECATED: Use gsm0808_create_paging2 instead.
+ * Create BSSMAP PAGING message.
+ * \param[in] imsi Mandatory paged IMSI in string representation
+ * \param[in] tmsi Optional paged TMSI
+ * \param[in] cil Cell Identity List (where to page)
+ * \param[in] chan_needed Channel Type needed
+ * \returns callee-allocated msgb with BSSMAP PAGING message */
+struct msgb *gsm0808_create_paging(const char *imsi, const uint32_t *tmsi,
+ const struct gsm0808_cell_id_list *cil,
+ const uint8_t *chan_needed)
+{
+ struct gsm0808_cell_id_list2 cil2 = {};
+
+ /* Mandatory emelents! */
+ OSMO_ASSERT(cil);
+
+ if (cil->id_list_len > GSM0808_CELL_ID_LIST2_MAXLEN)
+ return NULL;
+
+ cil2.id_discr = cil->id_discr;
+ memcpy(cil2.id_list, cil->id_list_lac, cil->id_list_len *
sizeof(cil2.id_list[0].id_list_lac));
+ cil2.id_list_len = cil->id_list_len;
+
+ return gsm0808_create_paging2(imsi, tmsi, &cil2, chan_needed);
+}
+
/*! Prepend a DTAP header to given Message Buffer
* \param[in] msgb Message Buffer
* \param[in] link_id Link Identifier */
diff --git a/src/gsm/gsm0808_utils.c b/src/gsm/gsm0808_utils.c
index 93e6074..c4e0d93 100644
--- a/src/gsm/gsm0808_utils.c
+++ b/src/gsm/gsm0808_utils.c
@@ -27,6 +27,8 @@
#include <string.h>
#include <errno.h>
#include <osmocom/gsm/protocol/gsm_08_08.h>
+#include <osmocom/gsm/gsm48.h>
+#include <osmocom/gsm/gsm0808_utils.h>
#define IP_V4_ADDR_LEN 4
#define IP_V6_ADDR_LEN 16
@@ -571,6 +573,75 @@
* \param[out] msg Message Buffer to which IE is to be appended
* \param[in] cil Cell ID List to be encoded
* \returns number of bytes appended to \a msg */
+uint8_t gsm0808_enc_cell_id_list2(struct msgb *msg,
+ const struct gsm0808_cell_id_list2 *cil)
+{
+ uint8_t *old_tail;
+ uint8_t *tlv_len;
+ unsigned int i;
+
+ OSMO_ASSERT(msg);
+ OSMO_ASSERT(cil);
+
+ msgb_put_u8(msg, GSM0808_IE_CELL_IDENTIFIER_LIST);
+ tlv_len = msgb_put(msg, 1);
+ old_tail = msg->tail;
+
+ msgb_put_u8(msg, cil->id_discr & 0x0f);
+
+ OSMO_ASSERT(cil->id_list_len <= GSM0808_CELL_ID_LIST2_MAXLEN)
+ switch (cil->id_discr) {
+ case CELL_IDENT_WHOLE_GLOBAL:
+ for (i = 0; i < cil->id_list_len; i++) {
+ const struct osmo_cell_global_id *id =
&cil->id_list[i].id_list_global;
+ struct gsm48_loc_area_id lai;
+ gsm48_generate_lai(&lai, id->lai.plmn.mcc,
id->lai.plmn.mnc, id->lai.lac);
+ memcpy(msgb_put(msg, sizeof(lai)), &lai, sizeof(lai));
+ msgb_put_u16(msg, id->cell_identity);
+ }
+ break;
+ case CELL_IDENT_LAC_AND_CI:
+ for (i = 0; i < cil->id_list_len; i++) {
+ const struct osmo_lac_and_ci_id *id =
&cil->id_list[i].id_list_lac_and_ci;
+ msgb_put_u16(msg, id->lac);
+ msgb_put_u16(msg, id->ci);
+ }
+ break;
+ case CELL_IDENT_CI:
+ for (i = 0; i < cil->id_list_len; i++)
+ msgb_put_u16(msg, cil->id_list[i].id_list_ci);
+ break;
+ case CELL_IDENT_LAI_AND_LAC:
+ for (i = 0; i < cil->id_list_len; i++) {
+ const struct osmo_location_area_id *id =
&cil->id_list[i].id_list_lai_and_lac;
+ struct gsm48_loc_area_id lai;
+ gsm48_generate_lai(&lai, id->plmn.mcc, id->plmn.mnc,
id->lac);
+ memcpy(msgb_put(msg, sizeof(lai)), &lai, sizeof(lai));
+ }
+ break;
+ case CELL_IDENT_LAC:
+ for (i = 0; i < cil->id_list_len; i++)
+ msgb_put_u16(msg, cil->id_list[i].id_list_lac);
+ break;
+ case CELL_IDENT_BSS:
+ case CELL_IDENT_NO_CELL:
+ /* Does not have any list items */
+ break;
+ default:
+ /* Support for other identifier list types is not implemented.
*/
+ OSMO_ASSERT(false);
+ }
+
+ *tlv_len = (uint8_t) (msg->tail - old_tail);
+ return *tlv_len + 2;
+}
+
+/*! DEPRECATED: Use gsm0808_enc_cell_id_list2 instead.
+ *
+ * Encode TS 08.08 Cell Identifier List IE
+ * \param[out] msg Message Buffer to which IE is to be appended
+ * \param[in] cil Cell ID List to be encoded
+ * \returns number of bytes appended to \a msg */
uint8_t gsm0808_enc_cell_id_list(struct msgb *msg,
const struct gsm0808_cell_id_list *cil)
{
@@ -606,11 +677,193 @@
return *tlv_len + 2;
}
+/* Decode 5-byte LAI list element data (see TS 08.08 3.2.2.27) into
MCC/MNC/LAC.
+ * Return 0 if successful, negative on error. */
+static int decode_lai(const uint8_t *data, uint16_t *mcc, uint16_t *mnc,
uint16_t *lac)
+{
+ struct gsm48_loc_area_id lai;
+
+ /* Copy data to stack to prevent unaligned access in
gsm48_decode_lai(). */
+ memcpy(&lai, data, sizeof(lai)); /* don't byte swap yet */
+
+ return gsm48_decode_lai(&lai, mcc, mnc, lac) ? -1 : 0;
+}
+
+static int parse_cell_id_global_list(struct osmo_cell_global_id *id_list,
const uint8_t *data, size_t remain,
+ size_t *consumed)
+{
+ struct osmo_cell_global_id *id;
+ uint16_t *ci_be;
+ size_t lai_offset;
+ int i = 0;
+
+ *consumed = 0;
+ while (remain >= sizeof(struct gsm48_loc_area_id) + sizeof(*ci_be)) {
+ if (i >= GSM0808_CELL_ID_LIST2_MAXLEN)
+ return -ENOSPC;
+ id = &id_list[i];
+ if (decode_lai(&data[lai_offset], &id->lai.plmn.mcc,
&id->lai.plmn.mnc, &id->lai.lac) != 0)
+ return -EINVAL;
+ lai_offset = 1 + i * (sizeof(struct gsm48_loc_area_id) +
sizeof(*ci_be));
+ ci_be = (uint16_t *)(&data[lai_offset + sizeof(struct
gsm48_loc_area_id)]);
+ id->cell_identity = osmo_load16be(ci_be);
+ *consumed += sizeof(struct gsm48_loc_area_id) + sizeof(*ci_be);
+ remain -= sizeof(struct gsm48_loc_area_id) + sizeof(*ci_be);
+ i++;
+ }
+
+ return i;
+}
+
+static int parse_cell_id_lac_and_ci_list(struct osmo_lac_and_ci_id *id_list,
const uint8_t *data, size_t remain,
+ size_t *consumed)
+{
+ uint16_t *lacp_be, *ci_be;
+ struct osmo_lac_and_ci_id *id;
+ int i = 0;
+
+ *consumed = 0;
+
+ if (remain < sizeof(*lacp_be) + sizeof(*ci_be))
+ return -EINVAL;
+
+ lacp_be = (uint16_t *)(&data[0]);
+ ci_be = (uint16_t *)(&data[2]);
+ while (remain >= sizeof(*lacp_be) + sizeof(*ci_be)) {
+ if (i >= GSM0808_CELL_ID_LIST2_MAXLEN)
+ return -ENOSPC;
+ id = &id_list[i];
+ id->lac = osmo_load16be(lacp_be);
+ id->ci = osmo_load16be(ci_be);
+ *consumed += sizeof(*lacp_be) + sizeof(*ci_be);
+ remain -= sizeof(*lacp_be) + sizeof(*ci_be);
+ lacp_be++;
+ ci_be++;
+ }
+
+ return i;
+}
+
+static int parse_cell_id_ci_list(uint16_t *id_list, const uint8_t *data,
size_t remain, size_t *consumed)
+{
+ const uint16_t *ci_be = (const uint16_t *)data;
+ int i = 0;
+
+ *consumed = 0;
+ while (remain >= sizeof(*ci_be)) {
+ if (i >= GSM0808_CELL_ID_LIST2_MAXLEN)
+ return -ENOSPC;
+ id_list[i++] = osmo_load16be(ci_be++);
+ consumed += sizeof(*ci_be);
+ remain -= sizeof(*ci_be);
+ }
+ return i;
+}
+
+static int parse_cell_id_lai_and_lac(struct osmo_location_area_id *id_list,
const uint8_t *data, size_t remain,
+ size_t *consumed)
+{
+ struct osmo_location_area_id *id;
+ int i = 0;
+
+ *consumed = 0;
+ while (remain >= sizeof(struct gsm48_loc_area_id)) {
+ if (i >= GSM0808_CELL_ID_LIST2_MAXLEN)
+ return -ENOSPC;
+ id = &id_list[i];
+ if (decode_lai(&data[1 + i * sizeof(struct gsm48_loc_area_id)],
&id->plmn.mcc, &id->plmn.mnc, &id->lac) != 0)
+ return -EINVAL;
+ *consumed += sizeof(struct gsm48_loc_area_id);
+ remain -= sizeof(struct gsm48_loc_area_id);
+ i++;
+ }
+
+ return i;
+}
+
+static int parse_cell_id_lac_list(uint16_t *id_list, const uint8_t *data,
size_t remain, size_t *consumed)
+{
+ const uint16_t *lac_be = (const uint16_t *)data;
+ int i = 0;
+
+ *consumed = 0;
+ while (remain >= sizeof(*lac_be)) {
+ if (i >= GSM0808_CELL_ID_LIST2_MAXLEN)
+ return -ENOSPC;
+ id_list[i++] = osmo_load16be(lac_be++);
+ *consumed += sizeof(*lac_be);
+ remain -= sizeof(*lac_be);
+ }
+ return i;
+}
+
/*! Decode Cell Identifier List IE
* \param[out] cil Caller-provided memory to store Cell ID list
* \param[in] elem IE value to be decoded
* \param[in] len Length of \a elem in bytes
* \returns number of bytes parsed; negative on error */
+int gsm0808_dec_cell_id_list2(struct gsm0808_cell_id_list2 *cil,
+ const uint8_t *elem, uint8_t len)
+{
+ uint8_t id_discr;
+ size_t bytes_elem = 0;
+ int list_len = 0;
+
+ OSMO_ASSERT(cil);
+ if (!elem)
+ return -EINVAL;
+ if (len == 0)
+ return -EINVAL;
+
+ memset(cil, 0, sizeof(*cil));
+
+ id_discr = *elem & 0x0f;
+ elem++;
+ len--;
+
+ switch (id_discr) {
+ case CELL_IDENT_WHOLE_GLOBAL:
+ list_len =
parse_cell_id_global_list(&cil->id_list[0].id_list_global, elem, len,
&bytes_elem);
+ break;
+ case CELL_IDENT_LAC_AND_CI:
+ list_len =
parse_cell_id_lac_and_ci_list(&cil->id_list[0].id_list_lac_and_ci, elem, len,
&bytes_elem);
+ break;
+ case CELL_IDENT_CI:
+ list_len = parse_cell_id_ci_list(&cil->id_list[0].id_list_ci,
elem, len, &bytes_elem);
+ break;
+ case CELL_IDENT_LAI_AND_LAC:
+ list_len =
parse_cell_id_lai_and_lac(&cil->id_list[0].id_list_lai_and_lac, elem, len,
&bytes_elem);
+ break;
+ case CELL_IDENT_LAC:
+ list_len = parse_cell_id_lac_list(&cil->id_list[0].id_list_lac,
elem, len, &bytes_elem);
+ break;
+ case CELL_IDENT_BSS:
+ case CELL_IDENT_NO_CELL:
+ /* Does not have any list items */
+ break;
+ default:
+ /* Remaining cell identification types are not implemented. */
+ return -EINVAL;
+ }
+
+ if (list_len < 0) /* parsing error */
+ return list_len;
+
+ cil->id_discr = id_discr;
+ cil->id_list_len = list_len;
+
+ /* One byte for the cell ID discriminator + any remaining bytes in
+ * the IE which were consumed by the parser functions above. */
+ return 1 + (int)bytes_elem;
+}
+
+/*! DEPRECATED: Use gsm0808_dec_cell_id_list2 instead.
+ *
+ * Decode Cell Identifier List IE
+ * \param[out] cil Caller-provided memory to store Cell ID list
+ * \param[in] elem IE value to be decoded
+ * \param[in] len Length of \a elem in bytes
+ * \returns number of bytes parsed; negative on error */
int gsm0808_dec_cell_id_list(struct gsm0808_cell_id_list *cil,
const uint8_t *elem, uint8_t len)
{
diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map
index 7a74718..81c905f 100644
--- a/src/gsm/libosmogsm.map
+++ b/src/gsm/libosmogsm.map
@@ -151,6 +151,7 @@
gsm0808_create_clear_complete;
gsm0808_create_clear_rqst;
gsm0808_create_paging;
+gsm0808_create_paging2;
gsm0808_create_dtap;
gsm0808_create_layer3;
gsm0808_create_layer3_aoip;
@@ -169,7 +170,9 @@
gsm0808_enc_encrypt_info;
gsm0808_dec_encrypt_info;
gsm0808_enc_cell_id_list;
+gsm0808_enc_cell_id_list2;
gsm0808_dec_cell_id_list;
+gsm0808_dec_cell_id_list2;
gsm0808_chan_type_to_speech_codec;
gsm0808_speech_codec_from_chan_type;
gsm0808_speech_codec_type_names;
diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c
index 189d548..b9b7e54 100644
--- a/tests/gsm0808/gsm0808_test.c
+++ b/tests/gsm0808/gsm0808_test.c
@@ -451,26 +451,26 @@
RSL_CHANNEED_TCH_ForH };
struct msgb *msg;
- struct gsm0808_cell_id_list cil;
+ struct gsm0808_cell_id_list2 cil;
uint32_t tmsi = 0x12345678;
uint8_t chan_needed = RSL_CHANNEED_TCH_ForH;
char imsi[] = "001010000001234";
cil.id_discr = CELL_IDENT_LAC;
- cil.id_list_lac[0] = 0x2342;
+ cil.id_list[0].id_list_lac = 0x2342;
cil.id_list_len = 1;
printf("Testing creating Paging Request\n");
- msg = gsm0808_create_paging(imsi, NULL, &cil, NULL);
+ msg = gsm0808_create_paging2(imsi, NULL, &cil, NULL);
VERIFY(msg, res, ARRAY_SIZE(res));
msgb_free(msg);
- msg = gsm0808_create_paging(imsi, &tmsi, &cil, NULL);
+ msg = gsm0808_create_paging2(imsi, &tmsi, &cil, NULL);
VERIFY(msg, res2, ARRAY_SIZE(res2));
msgb_free(msg);
- msg = gsm0808_create_paging(imsi, &tmsi, &cil, &chan_needed);
+ msg = gsm0808_create_paging2(imsi, &tmsi, &cil, &chan_needed);
VERIFY(msg, res3, ARRAY_SIZE(res3));
msgb_free(msg);
}
@@ -751,25 +751,24 @@
static void test_gsm0808_enc_dec_cell_id_list_lac()
{
- struct gsm0808_cell_id_list enc_cil;
- struct gsm0808_cell_id_list dec_cil;
+ struct gsm0808_cell_id_list2 enc_cil;
+ struct gsm0808_cell_id_list2 dec_cil;
struct msgb *msg;
uint8_t rc_enc;
int rc_dec;
memset(&enc_cil, 0, sizeof(enc_cil));
enc_cil.id_discr = CELL_IDENT_LAC;
- enc_cil.id_list_lac[0] = 0x0124;
- enc_cil.id_list_lac[1] = 0xABCD;
- enc_cil.id_list_lac[2] = 0x5678;
+ enc_cil.id_list[0].id_list_lac = 0x0124;
+ enc_cil.id_list[0].id_list_lac = 0xABCD;
+ enc_cil.id_list[0].id_list_lac = 0x5678;
enc_cil.id_list_len = 3;
msg = msgb_alloc(1024, "output buffer");
- rc_enc = gsm0808_enc_cell_id_list(msg, &enc_cil);
+ rc_enc = gsm0808_enc_cell_id_list2(msg, &enc_cil);
OSMO_ASSERT(rc_enc == 9);
- rc_dec = gsm0808_dec_cell_id_list(&dec_cil, msg->data + 2,
- msg->len - 2);
+ rc_dec = gsm0808_dec_cell_id_list2(&dec_cil, msg->data + 2, msg->len -
2);
OSMO_ASSERT(rc_dec == 7);
OSMO_ASSERT(memcmp(&enc_cil, &dec_cil, sizeof(enc_cil)) == 0);
@@ -779,8 +778,8 @@
static void test_gsm0808_enc_dec_cell_id_list_single_lac()
{
- struct gsm0808_cell_id_list enc_cil;
- struct gsm0808_cell_id_list dec_cil;
+ struct gsm0808_cell_id_list2 enc_cil;
+ struct gsm0808_cell_id_list2 dec_cil;
struct msgb *msg;
uint8_t cil_enc_expected[] = { GSM0808_IE_CELL_IDENTIFIER_LIST, 0x03,
0x05, 0x23, 0x42
@@ -790,16 +789,15 @@
memset(&enc_cil, 0, sizeof(enc_cil));
enc_cil.id_discr = CELL_IDENT_LAC;
- enc_cil.id_list_lac[0] = 0x2342;
+ enc_cil.id_list[0].id_list_lac = 0x2342;
enc_cil.id_list_len = 1;
msg = msgb_alloc(1024, "output buffer");
- rc_enc = gsm0808_enc_cell_id_list(msg, &enc_cil);
+ rc_enc = gsm0808_enc_cell_id_list2(msg, &enc_cil);
OSMO_ASSERT(rc_enc == 5);
OSMO_ASSERT(memcmp(cil_enc_expected, msg->data, msg->len) == 0);
- rc_dec = gsm0808_dec_cell_id_list(&dec_cil, msg->data + 2,
- msg->len - 2);
+ rc_dec = gsm0808_dec_cell_id_list2(&dec_cil, msg->data + 2, msg->len -
2);
OSMO_ASSERT(rc_dec == 3);
OSMO_ASSERT(memcmp(&enc_cil, &dec_cil, sizeof(enc_cil)) == 0);
@@ -809,21 +807,20 @@
static void test_gsm0808_enc_dec_cell_id_list_bss()
{
- struct gsm0808_cell_id_list enc_cil;
- struct gsm0808_cell_id_list dec_cil;
+ struct gsm0808_cell_id_list2 enc_cil;
+ struct gsm0808_cell_id_list2 dec_cil;
struct msgb *msg;
uint8_t rc_enc;
int rc_dec;
memset(&enc_cil, 0, sizeof(enc_cil));
- enc_cil.id_discr = CELL_IDENT_LAC;
+ enc_cil.id_discr = CELL_IDENT_BSS;
msg = msgb_alloc(1024, "output buffer");
- rc_enc = gsm0808_enc_cell_id_list(msg, &enc_cil);
+ rc_enc = gsm0808_enc_cell_id_list2(msg, &enc_cil);
OSMO_ASSERT(rc_enc == 3);
- rc_dec = gsm0808_dec_cell_id_list(&dec_cil, msg->data + 2,
- msg->len - 2);
+ rc_dec = gsm0808_dec_cell_id_list2(&dec_cil, msg->data + 2, msg->len -
2);
OSMO_ASSERT(rc_dec == 1);
OSMO_ASSERT(memcmp(&enc_cil, &dec_cil, sizeof(enc_cil)) == 0);
--
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Gerrit-PatchSet: 11
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
