Patch Set 11: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/6509/11/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:

Line 74: /* deprecated */
OSMO_DEPRECATED()?


https://gerrit.osmocom.org/#/c/6509/11/tests/gsm0808/gsm0808_test.c
File tests/gsm0808/gsm0808_test.c:

Line 817:       enc_cil.id_discr = CELL_IDENT_BSS;
mention this fix in the commit log?


-- 
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Gerrit-PatchSet: 11
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-HasComments: Yes

Reply via email to