Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/7601/1/regen-makefile.sh File regen-makefile.sh: Line 72: sed -i -e '/^compile:/ { n; n; n; s!touch $@!& \&\& sed -i -e "/\\/\\/ for .* on .*/d" $(GENERATED_HEADERS) $(GENERATED_SOURCES)! }' Makefile some comments posted on #osmocom: use separate strip_datetime_comments.sh script, prepend that before the touch (not after), and possibly call sed from a loop instead of feeding file names (in my memory sed can only do one file at a time, but not sure) -- To view, visit https://gerrit.osmocom.org/7601 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb538f602206535c06980f88191c1dabe3c4cd82 Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
