Patch Set 1:

I agree on all suggestions, except one:

Posix specifies that sed supports more than one input file:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html

Both the GNU sed and OpenBSD sed implementations support multiple input files.

Passing each file to sed individually would probably slow down the 'make 
compile' step unnecessarily.

-- 
To view, visit https://gerrit.osmocom.org/7601
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb538f602206535c06980f88191c1dabe3c4cd82
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-HasComments: No

Reply via email to