Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/10022 )
Change subject: add a VTY command which shows a specific mgcp endpoint ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/10022/1/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/#/c/10022/1/src/libosmo-mgcp/mgcp_vty.c@193 PS1, Line 193: vty_out(vty, "Endpoint %s0x%.2x:%s", > not sure if we should include a 0x here (I remember there has been confusion > around decimal vs hex o […] The idea to add rtpbridge/ prefix came from pmaier. I wrote this entire change sitting next to him and we were discussing it throughout the entire process. https://gerrit.osmocom.org/#/c/10022/1/src/libosmo-mgcp/mgcp_vty.c@256 PS1, Line 256: "Display information about an MGCP Media Gateway endpoint\n" > Common prefix with other commands, here 'show mgcp', should share similar doc > strings. […] Conceptually, a trunk contains endpoints. A trunk corresponds to a physical wire bundle which contains several cables, and each end of a cable inside this conceptual trunk corresponds to an endpoint. See RFC 3435 for more details. Issue OS#2660 is asking for a way to list endpoints., but a command which lists all trunks and their endpoints already exists ('show mgcp'). So I'm working under the assumption that this issue is asking for something which has already been implemented since the issue was filed. However, since the current implementation doesn't allow for filtering, I decided to implement a command which provides filtering of the existing output such that the state of specific endpoints can be viewed in isolation. Because any endpoint is part of a trunk, the commands currently require a trunk number in addition to an endpoint name. The tweaks to existing output which sneaked into this change are based on discussion between me and Philip. Philip helped me a lot in making sense of the media gateway in general and also the evolution of this code and its inconsistencies. We also discussed the UI of the new command together. If you are merely concerned that some design discussion involving Philip should happen, rest assured that it has already occured. If instead your intention is to take part in this design discussion yourself, I'm happy to start the discussion over from the top with you and Philip. But I also think we should not drag this out forever because this topic doesn't seem to be worth a huge deal. -- To view, visit https://gerrit.osmocom.org/10022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5330e697ec34bf215de91d44209048a8dc226d51 Gerrit-Change-Number: 10022 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Fri, 20 Jul 2018 11:20:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
