Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10022 )
Change subject: add VTY commands which show specific mgcp endpoints ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/10022/2/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/#/c/10022/2/src/libosmo-mgcp/mgcp_vty.c@309 PS2, Line 309: return ret; why are we stopping to dump endpoints just because one of them earlier in the list exposes some oddity? I think the user still deserves to see all endpoints. -- To view, visit https://gerrit.osmocom.org/10022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5330e697ec34bf215de91d44209048a8dc226d51 Gerrit-Change-Number: 10022 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 22 Aug 2018 19:54:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
