Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11290 )
Change subject: vty 'show bts'/'show trx': display IPs and ports ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/11290/3/src/osmo-bsc/bsc_vty.c@293 PS3, Line 293: /*! Dump the IP addresses and ports of the input signal link's timeslot. > > I suggest to have a function like e1inp_sign_link_name(const struct > > e1inp_sign_link *e1l) which wi […] I missed the fact that osmo_sock_get_name doesn't return a static buffer [like most parts of osmocom] but actually a heap-allocated string. I think we can just keep it. The difference between e1isl_dump_vty() and your e1isl_dump_vty_tcp() is that the former is used to print entire lines, i.e. dump an entire signaling link, while yours is used to print a trailer of a line. -- To view, visit https://gerrit.osmocom.org/11290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37f020fcdb68cafcdbdb621808483d1dd996354f Gerrit-Change-Number: 11290 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Wed, 10 Oct 2018 14:19:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
