Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11290 )
Change subject: vty 'show bts'/'show trx': display IPs and ports ...................................................................... Patch Set 4: Code-Review+2 (3 comments) https://gerrit.osmocom.org/#/c/11290/4/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/11290/4/src/osmo-bsc/bsc_vty.c@293 PS4, Line 293: /*! Dump the IP addresses and ports of the input signal link's timeslot. (so far we have doxygen only in libosmocore...) (and I'm not actually aware of anyone reading that, instead of the code comments. But that's a different topic.) https://gerrit.osmocom.org/#/c/11290/4/src/osmo-bsc/bsc_vty.c@301 PS4, Line 301: talloc_free(name); (reading this makes me want to write osmo_sock_get_name2()...) https://gerrit.osmocom.org/#/c/11290/4/src/osmo-bsc/bsc_vty.c@1066 PS4, Line 1066: e1isl_dump_vty_tcp(vty, trx->rsl_link); (IMHO better to have the VTY_NEWLINE down here. Well, not that important here, just as a general pattern when writing strings.) plus, I notice it follows the general pattern of the existing e1isl_dump_vty() code. So nm. -- To view, visit https://gerrit.osmocom.org/11290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I37f020fcdb68cafcdbdb621808483d1dd996354f Gerrit-Change-Number: 11290 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Fri, 12 Oct 2018 10:57:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
