osmith has posted comments on this change. ( https://gerrit.osmocom.org/11725 )
Change subject: use autotools to add "make install" target ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/11725/5/configure.ac File configure.ac: https://gerrit.osmocom.org/#/c/11725/5/configure.ac@22 PS5, Line 22: if ! $srcdir/check-depends.sh > I think this should be builddir instead, and make sure check-depends.sh is > added to EXTRA_DIST. […] Good point with "make distcheck", I'll update the patches to make sure that this works. -- To view, visit https://gerrit.osmocom.org/11725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7036fae062ee783cb132b14608827a82c5e7c7 Gerrit-Change-Number: 11725 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Mon, 19 Nov 2018 10:50:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No