Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11725 )
Change subject: use autotools to add "make install" target ...................................................................... Patch Set 6: Code-Review+1 (1 comment) +1, leaving for Neels the +2 since he had some comment sin previous patches. https://gerrit.osmocom.org/#/c/11725/6/Makefile.am File Makefile.am: https://gerrit.osmocom.org/#/c/11725/6/Makefile.am@2 PS6, Line 2: share_path = "$(DESTDIR)$(prefix)/share/osmo-gsm-manuals" would be clearer to name it destdir_sharepath or so, I first though it was related to share_files (sources). -- To view, visit https://gerrit.osmocom.org/11725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e7036fae062ee783cb132b14608827a82c5e7c7 Gerrit-Change-Number: 11725 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Tue, 20 Nov 2018 17:32:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes