Max has posted comments on this change. ( https://gerrit.osmocom.org/11911 )
Change subject: IPA: move duplicated error handling into function ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11911/3/src/gsm/ipa.c File src/gsm/ipa.c: https://gerrit.osmocom.org/#/c/11911/3/src/gsm/ipa.c@545 PS3, Line 545: * \param[out] ret result of recv() will be stored in here. > You are still not mentioning here that ret also contains errno if ret >0 Because it doesn't: if ret > 0 than it does not contain errno - see the code. -- To view, visit https://gerrit.osmocom.org/11911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0147bffaf04b0baf97e5cca22948bd0e116668f Gerrit-Change-Number: 11911 Gerrit-PatchSet: 3 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 26 Nov 2018 11:27:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
