Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11911 )
Change subject: IPA: move duplicated error handling into function ...................................................................... Patch Set 4: > So I appreciate the code dup removal, but I believe in this > instance it comes at a cost, which is too high (both readability > wise and time spent wise). I'm not against merging it, but tbh I agree with Neels here, specially after 2nd patch following this one, it makes no much sense or I see no real gain in doing this. -- To view, visit https://gerrit.osmocom.org/11911 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0147bffaf04b0baf97e5cca22948bd0e116668f Gerrit-Change-Number: 11911 Gerrit-PatchSet: 4 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 03 Dec 2018 18:21:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
