Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers ...................................................................... Patch Set 3: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/12017/3/include/osmocom/core/msgb.h File include/osmocom/core/msgb.h: https://gerrit.osmocom.org/#/c/12017/3/include/osmocom/core/msgb.h@133 PS3, Line 133: /*! obtain L4 header of msgb */ All these l4 functions belong to another patch imho. Are they going to be used by someone in follow up patches? https://gerrit.osmocom.org/#/c/12017/3/include/osmocom/core/msgb.h@612 PS3, Line 612: /* msgb test/debug helpers */ IMHO having all these is too much cruft. Let's keep the print parameter in the macro and remove all _print ones, I think it's fine enough. https://gerrit.osmocom.org/#/c/12017/3/include/osmocom/core/msgb.h@709 PS3, Line 709: bool msgb_cmpr_l3(const char *f, size_t l, const struct msgb *msg, const uint8_t *data, size_t len, bool print); This should not be there anymore. https://gerrit.osmocom.org/#/c/12017/3/src/msgb.c File src/msgb.c: https://gerrit.osmocom.org/#/c/12017/3/src/msgb.c@211 PS3, Line 211: m_dump = msgb_hexdump(msg); Since this function can be quite heavy, let's do: m_dump = print ? msgb_hexdump(msg) : NULL; https://gerrit.osmocom.org/#/c/12017/3/src/msgb.c@252 PS3, Line 252: printf("%s:%zu %s() L%u data mismatch:\nexpected %s\n ", extra whitespace here right? -- To view, visit https://gerrit.osmocom.org/12017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 3 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 30 Nov 2018 16:49:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes