Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers ...................................................................... Patch Set 5: > I think we should avoid using printf() in libosmocore In general I'd agree but those are "test helpers" (see commit description) which are intended to be used in tests/ code where printf() usage is common. For use outside of tests/ there're variants which don't print anything implemented via #define wrappers. -- To view, visit https://gerrit.osmocom.org/12017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 5 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 03 Dec 2018 14:52:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
