Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12478 )
Change subject: VLR: send CHECK-IMEI to EIR/HLR ...................................................................... Patch Set 8: (2 comments) https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr.c@1016 PS8, Line 1016: (void *)&gsup->cause); What is the meaning of cause in successful case? https://gerrit.osmocom.org/#/c/12478/8/src/libvlr/vlr.c@1018 PS8, Line 1018: (void *)&gsup->cause); Same here, isn't it only being sent when msgt == OSMO_GSUP_MSGT_CHECK_IMEI_ERROR? -- To view, visit https://gerrit.osmocom.org/12478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife868ed71c36cdd02638072abebf61fc949080a7 Gerrit-Change-Number: 12478 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Fri, 11 Jan 2019 13:45:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No