Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12478 )
Change subject: VLR: send CHECK-IMEI to EIR/HLR ...................................................................... Patch Set 10: Code-Review+1 (2 comments) just cosmetics... https://gerrit.osmocom.org/#/c/12478/10/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/12478/10/src/libvlr/vlr.c@664 PS10, Line 664: * IMEI to the HLR DB as side effect (OS#2541). */ In general, it's a good thing to spread context info, but not so good if that info is volatile: if at some point we would add an EIR or a IMEI white/blacklist, then we'd have to revisit all these places and correct the context info, in a completely separate code tree. So I guess it would be better to leave the info close to its home, like, rather avoid explaining OsmoHLR in OsmoMSC code, and avoid explaining OsmoMSC in OsmoHLR code; if you have to, use as non-specific references to other programs as possible. Further complication here is that even if using the Osmocom stack, some users may choose a GSUP<->MAP translation and/or use a completely different HLR than OsmoHLR. So I'd just shut up about it here and explain everything in OsmoHLR, preferably in only one place, to avoid diverse info. https://gerrit.osmocom.org/#/c/12478/10/src/libvlr/vlr.c@668 PS10, Line 668: uint8_t imei_enc[GSM23003_IMEI_NUM_DIGITS+2] = {0}; (maybe mention +2 for the IE header?) -- To view, visit https://gerrit.osmocom.org/12478 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife868ed71c36cdd02638072abebf61fc949080a7 Gerrit-Change-Number: 12478 Gerrit-PatchSet: 10 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 Jan 2019 17:24:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
