Max has posted comments on this change. ( https://gerrit.osmocom.org/12547 )

Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
......................................................................


Patch Set 2:

> it might avoid confusion if we don't call it CTRL in Osmocom... if not in the 
> code, then maybe at least in logging? TRXCTRL? TRXCTL?

It's called TRXCTRL in OsmoTRX (see 1595ddaa5fc1dcc4e04168e43fc82e3c71fdb3fd) 
so I think it's better to do the same in here.


--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <[email protected]>
Gerrit-Comment-Date: Mon, 14 Jan 2019 18:43:37 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to