Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/12547 )
Change subject: trx_toolkit/{ctrl,data}_if.py: add init log message
......................................................................
Patch Set 3:
> it might avoid confusion if we don't call it CTRL in Osmocom... if
> not in the code, then maybe at least in logging? TRXCTRL? TRXCTL?
TBH, I don't see any confusion with libosmoctrl's CTRL interface (which could
be also named in more concrete way, e.g. OCTRL) as TRX toolkit is not using
this library and will never do.
But I understand that some users, who are just starting to use this framework,
may confuse this control interface with libosmoctrl's one.
So, ok, let's stick to TRXC / TRXD at least in logging.
I'll do this in a separate change.
--
To view, visit https://gerrit.osmocom.org/12547
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a2caf6999ed4f33df76328e48ff5076d166d9fe
Gerrit-Change-Number: 12547
Gerrit-PatchSet: 3
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Comment-Date: Mon, 14 Jan 2019 20:27:43 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
