Max has posted comments on this change. ( https://gerrit.osmocom.org/12573 )
Change subject: Add function to combine nibbles into byte ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12573/1/include/osmocom/core/bits.h File include/osmocom/core/bits.h: https://gerrit.osmocom.org/#/c/12573/1/include/osmocom/core/bits.h@52 PS1, Line 52: hi Value to be placed in MSB nibble > Copy pasted ;) Did you mean MSB? Sure thing :) -- To view, visit https://gerrit.osmocom.org/12573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I380687c31a787c0a109819f7c3b2946eae52675e Gerrit-Change-Number: 12573 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 16 Jan 2019 10:00:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
