Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12573 )
Change subject: Add function to combine nibbles into byte ...................................................................... Patch Set 2: Code-Review-1 > I think this is API bloat. > If you start like this, where will it lead? Hehe, this reminds me the time when I was involved in web-development. jQuery has become so popular, so multiple funny questions from noobs began to appear on StackOverflow (not only), e.g.: how to sum two numbers using jQuery? :D So, in general I am agree with Neels. -- To view, visit https://gerrit.osmocom.org/12573 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I380687c31a787c0a109819f7c3b2946eae52675e Gerrit-Change-Number: 12573 Gerrit-PatchSet: 2 Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 16 Jan 2019 12:54:26 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
