Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences ...................................................................... Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/12625/4/include/osmocom/bsc/gsm_data.h@121 PS4, Line 121: struct channel_mode_and_rate ch_mode_rate_alt; Are there really only two possible mode,rate combinations? In my idea for this, we would call lchan_select() from that loop that iterates all possible mode,rate combinations. It seems odd to just collect two of the possible combinations and try to pick those only later. Maybe there's something I'm not seeing, might be good to look at it together, in person. -- To view, visit https://gerrit.osmocom.org/12625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51 Gerrit-Change-Number: 12625 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Tue, 22 Jan 2019 13:50:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
