Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12625 )
Change subject: assignment_fsm: fix channel allocator preferences ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/#/c/12625/4/src/osmo-bsc/assignment_fsm.c@377 PS4, Line 377: if (lchan_type_compat_with_mode(conn->lchan->type, &req->ch_mode_rate_pref)) { > -1: code dup: please implement this only once in a utility function, and call > it twice: once for the […] mistake in my comment: should be if (!conn->assignment.new_lchan) in both places -- To view, visit https://gerrit.osmocom.org/12625 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5239e05c1cfbcb8af28f43373a58fa6c2d216c51 Gerrit-Change-Number: 12625 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 24 Jan 2019 16:58:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
