Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface ...................................................................... Patch Set 33: (1 comment) https://gerrit.osmocom.org/#/c/11642/33/src/libmsc/sgs_iface.c File src/libmsc/sgs_iface.c: https://gerrit.osmocom.org/#/c/11642/33/src/libmsc/sgs_iface.c@112 PS33, Line 112: ran_conn_put(conn, RAN_CONN_USE_SGs_SERVICE); I need to understand the intention, so I can move this to the inter-MSC role stuff without breaking it: I thought the above ran_conn_get(USE_SGs) would remain in place until the SGs conn gets released (if there is such a thing). Why is this put() down again immediately? Or, from another angle, why do we then need to get() it in the first place? (does it get deallocated by those events otherwise?) And then, in the end of this function, the conn that we return, is it only used by compl_l3 (??) and gets deallocated immediately? -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 33 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Wed, 23 Jan 2019 00:25:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
