Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11642 )
Change subject: Add SGs Interface ...................................................................... Patch Set 30: (1 comment) vty_dump_one_conn() in msc_vty.c: https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/11642/30/src/libmsc/msc_vty.c@564 PS30, Line 564: conn->via_ran == OSMO_RAT_UTRAN_IU ? "Iu" : "A", here maybe rather use osmo_rat_type_name(), otherwise all SGs conns are shown as "A". -- To view, visit https://gerrit.osmocom.org/11642 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73359925fc1ca72b33a1466e6ac41307f2f0b11d Gerrit-Change-Number: 11642 Gerrit-PatchSet: 30 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Sun, 20 Jan 2019 22:58:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
