Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13347 )
Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2592 PS1, Line 2592: static int rslms_is_gprs_susp_req(struct msgb *msg) Can we please merge this function inside rslms_is_meas_rep and return GSM48_MT_* ? Feel free to keep rslms_is_meas_rep and rslms_is_gprs_susp_req as shim to this new function. https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2636 PS1, Line 2636: tlli = osmo_htonl(gsr->tlli); shouldn't this be osmo_ntohl? -- To view, visit https://gerrit.osmocom.org/13347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f Gerrit-Change-Number: 13347 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Wed, 20 Mar 2019 15:28:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
