osmith has posted comments on this change. ( https://gerrit.osmocom.org/13347 )
Change subject: Forward GPRS SUSPEND REQ from DCCH to PCU socket ...................................................................... Patch Set 1: (3 comments) Comments addressed, please have another look. I have tested this again with a sysmoBTS 1002 and it is still working as expected. https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h File include/osmo-bts/pcuif_proto.h: https://gerrit.osmocom.org/#/c/13347/1/include/osmo-bts/pcuif_proto.h@14 PS1, Line 14: > (stray tab) Done https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2592 PS1, Line 2592: static int rslms_is_gprs_susp_req(struct msgb *msg) > I care about having things resolved as quickly as possible, so if you have > time and know what needs […] Done https://gerrit.osmocom.org/#/c/13347/1/src/common/rsl.c@2636 PS1, Line 2636: tlli = osmo_htonl(gsr->tlli); > correct, it's network to host order that we need here. Done -- To view, visit https://gerrit.osmocom.org/13347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c1af662c8f0d3d22da200638480f6ef05c3ed1f Gerrit-Change-Number: 13347 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Mar 2019 15:00:39 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No