osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15459 )
Change subject: Forward ETWS Primary Notification to MS ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/15459/3/src/gprs_ms.h File src/gprs_ms.h: https://gerrit.osmocom.org/#/c/15459/3/src/gprs_ms.h@43 PS3, Line 43: struct gprs_rlcmac_ms { : bool app_info_send; : }; Thanks for the overview of alternatives! I've updated it to behave like that: > The simplest C way would be to add bool app_info_send as a public member > field, so anyone can read and write directly, which is how we do it in pretty > much every other osmocom code base. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie35959f833f46bde5f2126314b6f96763f863b36 Gerrit-Change-Number: 15459 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 11 Sep 2019 13:44:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@gnumonks.org> Comment-In-Reply-To: osmith <osm...@sysmocom.de> Gerrit-MessageType: comment
