laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15459 )
Change subject: Forward ETWS Primary Notification to MS ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/15459/5/src/gprs_rlcmac.cpp File src/gprs_rlcmac.cpp: https://gerrit.osmocom.org/#/c/15459/5/src/gprs_rlcmac.cpp@55 PS5, Line 55: bv = bitvec_alloc(req->len + 1, tall_pcu_ctx); no check or ASSERT of bitvec_alloc() return value. Also, no need to actually allocate a bitvec dynamically. you can simply msgb_alloc and then have the bitvec point to data of the msgb? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie35959f833f46bde5f2126314b6f96763f863b36 Gerrit-Change-Number: 15459 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 11 Sep 2019 16:28:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
