pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15494 )
Change subject: Introduce multiple paging attempts ...................................................................... Patch Set 1: (5 comments) https://gerrit.osmocom.org/#/c/15494/1/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: https://gerrit.osmocom.org/#/c/15494/1/include/osmocom/msc/gsm_data.h@126 PS1, Line 126: #define MSC_PAGING_RESPONSE_TIMER_DEFAULT 10 Looks like we want to move this one to osmo_tdef. https://gerrit.osmocom.org/#/c/15494/1/include/osmocom/msc/gsm_data.h@127 PS1, Line 127: #define MSC_PAGING_ATTEMPTS 3 MSC_PAGING_ATTEMPTS_DEFAULT https://gerrit.osmocom.org/#/c/15494/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/15494/1/src/libmsc/msc_vty.c@572 PS1, Line 572: "Set to default attempts (" OSMO_STRINGIFY_VAL(MSC_PAGING_ATTEMPTS) " seconds)\n" MSC_PAGING_ATTEMPTS_DEFAULT Remove seconds from there. https://gerrit.osmocom.org/#/c/15494/1/src/libmsc/msc_vty.c@576 PS1, Line 576: gsmnet->paging_attempts = MSC_PAGING_ATTEMPTS; MSC_PAGING_ATTEMPTS_DEFAULT https://gerrit.osmocom.org/#/c/15494/1/src/libmsc/msc_vty.c@709 PS1, Line 709: if (gsmnet->paging_attempts != MSC_PAGING_ATTEMPTS) MSC_PAGING_ATTEMPTS_DEFAULT -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I32c47958939a4a29292832289f9d29905731d7f3 Gerrit-Change-Number: 15494 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: efistokl <myk...@kingmuffin.com> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2019 12:09:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
