fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15494 )
Change subject: Introduce multiple paging attempts ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/15494/1/include/osmocom/msc/paging.h File include/osmocom/msc/paging.h: https://gerrit.osmocom.org/#/c/15494/1/include/osmocom/msc/paging.h@38 PS1, Line 38: int In struct 'gsm_network' you're using unsigned int. Can it be negative here? If no, let's keep to code consistent. https://gerrit.osmocom.org/#/c/15494/1/src/libmsc/msc_net_init.c File src/libmsc/msc_net_init.c: https://gerrit.osmocom.org/#/c/15494/1/src/libmsc/msc_net_init.c@61 PS1, Line 61: MSC_PAGING_RESPONSE_TIMER_DEFAULT Ctrl + C -> Ctrl + V error, you definitely need MSC_PAGING_ATTEMPTS here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15494 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I32c47958939a4a29292832289f9d29905731d7f3 Gerrit-Change-Number: 15494 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: efistokl <myk...@kingmuffin.com> Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2019 20:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
