pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 )
Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/15677/2/src/fsm.c File src/fsm.c: https://gerrit.osmocom.org/c/libosmocore/+/15677/2/src/fsm.c@198 PS2, Line 198: void osmo_fsm_set_dealloc_ctx(void *ctx) > The choice to allow is whether to use osmo_select_main_ctx() or > osmo_select_main() and/or a manual c […] I neither see the point in delaying free() of instances which have no problem in being freed instantly. I'm not against merging all this work, but my feeling is you try to kill several flies with nuclear weapons with all this work. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78 Gerrit-Change-Number: 15677 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 25 Oct 2019 11:43:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
