pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15677 )
Change subject: add osmo_fsm_set_dealloc_ctx(), to help with use-after-free ...................................................................... Patch Set 3: > (If I could go back, I would actually undo osmo_fsm_term_safely() and rather > use this more elegant solution instead.) You can still go back if you think it's needed, it was not yet released as far as I know. > If you doubt the necessity of solving these problems I'm not saying these problems don't exist or don't need to be solved, I'm just saying I'm not liking the approaches I see are being taken here. I still have the feeling it be better fixing it by adding delete_cb or passing some specific return codes somewhere like we do with -EBADF during read_cb() in other libosmocore APIs. But since I cannot spend time on this, go ahead with merging this if you think it's really the best or only way. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15677 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ief4dba9ea587c9b4aea69993e965fbb20fb80e78 Gerrit-Change-Number: 15677 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 30 Oct 2019 11:42:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
