pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15946 )
Change subject: BSSMAP: decode Codec List (BSS Supported) ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/15946/1/src/libmsc/ran_msg_a.c File src/libmsc/ran_msg_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/15946/1/src/libmsc/ran_msg_a.c@127 PS1, Line 127: /* This IE is not critical, do not abort with error. */ then probably set log level as WARN/NOTICE? https://gerrit.osmocom.org/c/osmo-msc/+/15946/1/src/libmsc/ran_msg_a.c@129 PS1, Line 129: ran_dec_msg.compl_l3.codec_list_bss_supported = &codec_list_bss_supported; > aren't you assigning a pointer to a stack variable here, which will have no > significance after the f […] I have the feeling that's intended and fine here. It's like our usual tlv_parsed, used during the current code path and if you need to keep something later then you must copy it. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15946 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I66c735c79e982388f06b5de783aa584c9d13569e Gerrit-Change-Number: 15946 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Mon, 04 Nov 2019 10:22:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment