pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15953 )
Change subject: add full SDP codec information to the MNCC socket ...................................................................... Patch Set 1: Code-Review+1 (2 comments) This patch is huge, I'd welcome some splitting into several patches if possible. https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/include/osmocom/msc/transaction.h File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/include/osmocom/msc/transaction.h@a90 PS1, Line 90: /* if true, TCH_RTP_CREATE is sent after the Removing this seems non-related? https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/src/libmsc/gsm_04_08_cc.c File src/libmsc/gsm_04_08_cc.c: https://gerrit.osmocom.org/c/osmo-msc/+/15953/1/src/libmsc/gsm_04_08_cc.c@634 PS1, Line 634: trans_free(trans); trans->callref = 0 needed here? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8c3b2de53ffae4ec3a66b9dabf308c290a2c999f Gerrit-Change-Number: 15953 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2019 11:02:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
