pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 )
Change subject: msc: overhaul voice call testing ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938/1/library/MGCP_Templates.ttcn File library/MGCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938/1/library/MGCP_Templates.ttcn@456 PS1, Line 456: function f_mgcp_find_param_entry(MgcpParameterList pars, MgcpInfoCode code, out charstring ret) This can probably be a different patch. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938/1/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938/1/msc/BSC_ConnectionHandler.ttcn@755 PS1, Line 755: got_osmux := 0 got_osmux_cnt? otherwise it looks like a bool. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8b82476f55a98f7a94d5c4f1cd80eac427b2d20f Gerrit-Change-Number: 15938 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 04 Nov 2019 11:20:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
