neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15953 )
Change subject: add full SDP codec information to the MNCC socket ...................................................................... Patch Set 1: > This patch is huge, I'd welcome some splitting into several patches if > possible. I fully agree, and I tried that. The problem: it is hard to make parts of it work without the rest. After hitting complex problems trying to split things out, I flinched and left it in one. I can spend (probably a lot of) time on separate patches if that is required, or we can agree on another "medium-large refactoring" bomb... If the opinion is that it should be split, I can try harder. For example, I wanted to split out the part that moves the CN side CRCX to an earlier time, but that also entails changing the the callback functions' names and the sequence of what calls which. Then I would need to sort of undo the part that figures out the codecs from SDP, which IIRC changes the code flow and needs more thinking to get a fully working osmo-msc. We would get an intermediate stage osmo-msc that no-one will be using in practice and which probably has odd problems that are fixed by the rest of this patch; I'd need to fix those in creative ways... I could split out the SDP parsing stuff, but then that would have no callers. I could split out the Codec List (BSS Supported) handling, but I store the result in the new cc_sdp struct. I'd have to invent some other storage for that and undo it in the second part of the patch. Or I could split it out without using it anywhere. Ah, I did that already in I66c735c79e982388f06b5de783aa584c9d13569e ... I'm open for opinions here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8c3b2de53ffae4ec3a66b9dabf308c290a2c999f Gerrit-Change-Number: 15953 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 04 Nov 2019 14:24:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
