pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15281 )
Change subject: gprs_bssgp_destroy(): fix NULL-pointer dereference ...................................................................... Patch Set 4: Code-Review-2 (1 comment) https://gerrit.osmocom.org/c/osmo-pcu/+/15281/4/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/15281/4/src/gprs_bssgp_pcu.cpp@977 PS4, Line 977: if (the_pcu.bctx != NULL) { Better move this into the free() API. free() APIs are usually expected to allow NULL pointers. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I42cb911a679b9198fd06e74b42f1e2cb28323de9 Gerrit-Change-Number: 15281 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 08 Nov 2019 19:11:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
