pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/16760 )
Change subject: configure: check for sctp.h ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/c/libosmo-netif/+/16760/1/configure.ac File configure.ac: https://gerrit.osmocom.org/c/libosmo-netif/+/16760/1/configure.ac@100 PS1, Line 100: AC_CHECK_HEADERS(netinet/sctp.h,,AC_MSG_ERROR(netinet/sctp.h not found)) Support check for libsctp here is wrong actually. Same for DAHDI probably. We should have explicit build enable/disable flags for those instead, and the header should only be checked in the event --enable-libsctp is passed (the default). See libosmocore (libsctp) and libosmo-abis(dahdi) as an example: --disable-libsctp Do not enable socket multiaddr APIs requiring libsctp AC_ARG_ENABLE([libsctp], [AS_HELP_STRING([--disable-libsctp], [Do not enable socket multiaddr APIs requiring libsctp])], [ENABLE_LIBSCTP=$enableval], [ENABLE_LIBSCTP="yes"]) AM_CONDITIONAL(ENABLE_LIBSCTP, test x"$ENABLE_LIBSCTP" = x"yes") AS_IF([test "x$ENABLE_LIBSCTP" = "xyes"], [ old_LIBS=$LIBS AC_SEARCH_LIBS([sctp_bindx], [sctp], [ AC_DEFINE(HAVE_LIBSCTP, 1, [Define 1 to enable SCTP support]) AC_SUBST(HAVE_LIBSCTP, [1]) if test -n "$ac_lib"; then AC_SUBST(LIBSCTP_LIBS, [-l$ac_lib]) fi ], [ AC_MSG_ERROR([sctp_bindx not found in searched libs])]) LIBS=$old_LIBS ]) AC_ARG_ENABLE([dahdi], AC_HELP_STRING([--disable-dahdi], [disable support for DAHID ISDN (E1/T1) cards [default=yes]]), [enable_dahdi="$enableval"], [enable_dahdi="yes"]) AM_CONDITIONAL(ENABLE_DAHDI, test "x$enable_dahdi" = "xyes") if test "x$enable_dahdi" = "xyes"; then AC_CHECK_HEADERS([dahdi/user.h],[],[AC_MSG_ERROR([DAHDI input driver enabled but DAHDI not found])]) else AC_MSG_WARN([DAHDI input driver will not be built]) fi -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/16760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I4b3e1f1894f13ac1175a71a5139c02a2633be26d Gerrit-Change-Number: 16760 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jan 2020 17:52:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
