neels has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18071 )
Change subject: Extract PLMN digits from IMSI in non-batch programming scenario ...................................................................... Patch Set 7: Code-Review-1 (1 comment) The aim of this patch is to fix a bug, or to make invocation more convenient? After this patch, is it still possible to program an IMSI that mismatches the MCC,MNC? (I'm not sure that I understand the difference between batch and non-batch...) https://gerrit.osmocom.org/c/pysim/+/18071/7/pySim-prog.py File pySim-prog.py: https://gerrit.osmocom.org/c/pysim/+/18071/7/pySim-prog.py@275 PS7, Line 275: if not mcc.isdigit() or not mnc.isdigit(): There is mcc and mnc validation up here, but your patch changes them again below. The extraction should happen above this line instead. Then you also don't need to code-dup the lpad() calls, but simply let the mcc and mnc be left-padded as normally. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I48bf7cf94d23960db944f39b84f0c3f057d89659 Gerrit-Change-Number: 18071 Gerrit-PatchSet: 7 Gerrit-Owner: herlesupreeth <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2020 14:25:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
