laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19141 )
Change subject: socket.h: introduce osmo_sockaddr to hold v4 and v6 endpoints ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19141/1/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/19141/1/include/osmocom/core/socket.h@25 PS1, Line 25: struct osmo_sockaddr { > How do you differentiate the address family in here? Do all contain a type > field in the same address […] yes, I think it's universally the case that you always have a "sin_addr" / "sin6_addr" / ... field as first member in the 'struct sockaddr_foo'. Ugly, but has been used in BSD sockets API for decades :/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19141 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If80172373735193401af872b18e1ff00c93880e7 Gerrit-Change-Number: 19141 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 06 Jul 2020 19:53:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
