fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/19310 )

Change subject: encoding: assert() presence of Downlink TBF
......................................................................


Patch Set 1:

(1 comment)

Sorry for late reply, somehow I missed these comments. Given that this is not 
supposed to happen, logging is not really important in this case. I really like 
the idea of sending crash indications over GSMTAP though.

https://gerrit.osmocom.org/c/osmo-pcu/+/19310/1/src/encoding.cpp
File src/encoding.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/19310/1/src/encoding.cpp@497
PS1, Line 497:          OSMO_ASSERT(as_dl_tbf(tbf) != NULL);
> UNRELATED: maybe we should make sure that osmo_panic_default() sends a GSMTAP 
> packet, if gsmtap logg […]
Indeed, this is an interesting idea. Especially if this "crash indication" 
would additionally contain the backtrace. We should definitely create a ticket.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/19310
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6e46ba42650f0db2399649b536a1d2b3f0fcbf04
Gerrit-Change-Number: 19310
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Aug 2020 17:33:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: laforge <lafo...@osmocom.org>
Gerrit-MessageType: comment

Reply via email to