pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21058 )
Change subject: osmo-gbproxy: Implement nsvc-state ctrl command ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/21058/1/src/gbproxy/gb_proxy_ctrl.c File src/gbproxy/gb_proxy_ctrl.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21058/1/src/gbproxy/gb_proxy_ctrl.c@48 PS1, Line 48: data->is_sgsn ? "SGSN" : "BSS" ); do we usually use caps in ctrl message data stuff? I don't think so. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0beb572103803f3ee4ecb28d9bf2e3139e0f8aa4 Gerrit-Change-Number: 21058 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 06 Nov 2020 12:55:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment