Sven Panne <svenpa...@gmail.com> writes:

> 2016-02-15 20:16 GMT+01:00 Ben Gamari <b...@smart-cactus.org>:
>
>> Sven Panne <svenpa...@gmail.com> writes:
>> The reason for this is that the things missing signatures are pattern
>> synonyms, which have their warnings controlled by -Wmissing-pat-syn-sigs
>> [1], which is enabled in -Wall by default.
>>
>
> OK, I missed that in the release notes. Two points here:
>
>    * The naming of the options is horrible, sometimes it's "sigs",
> sometimes it's "signatures". I would prefer if we named them consistently
> (probably "signatures", it's easier to search for).
>
Indeed, I noticed that this when looking this up for you. The
inconsistency is quite unfortunate. Perhaps -Wmissing-pattern-signatures
or -Wmissing-patsyn-signatures? -Wmissing-pattern-synonym-signatures is
a bit of a mouthful.

>    * Given the myriad of warning-related options, It is *extremely* hard to
> figure out which one caused the actual warning in question. The solution to
> this is very easy and done this way in clang/gcc (don't remember which one,
> I'm switching quite often): Just suffix all warnings consistently with the
> option causing it, e.g.
>
Indeed, this is #10752, as hvr pointed out. I'm not sure whether David
has done anything on this yet; feel free to take a stab at implementing
it if you have some free time.

- Ben

Attachment: signature.asc
Description: PGP signature

_______________________________________________
ghc-devs mailing list
ghc-devs@haskell.org
http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Reply via email to