| > When submitting a review, I often want to add an overall comment, not | related to a particular line of code? How do I do that? | | I do that by going back to the "Discussion" tab and adding something at the | bottom.
But alas then it does not form part of the review, landing as a single email. It becomes a separate, disconnected comment. Simon | -----Original Message----- | From: Evan Laforge <qdun...@gmail.com> | Sent: 08 January 2019 12:48 | To: Simon Peyton Jones <simo...@microsoft.com> | Cc: ghc-devs <ghc-devs@haskell.org> | Subject: Re: Reviews | | On Tue, Jan 8, 2019 at 6:01 PM Simon Peyton Jones via ghc-devs <ghc- | d...@haskell.org> wrote: | > | > When reviewing a MR, I sometimes want to look at (and even add comments | to) code that isn’t displayed in the MR window. With Phab there was a | “show 20 more lines” link, and even “show the whole file”. How do I do | that in GitLab? | | If you click on the gray-ish text on the top and bottom edges of the | displayed greed/red diff areas, it should give you some more lines. | | > When submitting a review, I often want to add an overall comment, not | related to a particular line of code? How do I do that? | | I do that by going back to the "Discussion" tab and adding something at the | bottom. _______________________________________________ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs