[
https://issues.apache.org/jira/browse/GIRAPH-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123907#comment-13123907
]
jirapos...@reviews.apache.org commented on GIRAPH-48:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2322/
-----------------------------------------------------------
Review request for giraph.
Summary
-------
9 unittests failed due to
java.lang.IllegalArgumentException
at
java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:589)
at
java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:480)
at java.util.concurrent.Executors.newFixedThreadPool(Executors.java:59)
at
org.apache.giraph.comm.BasicRPCCommunications.<init>(BasicRPCCommunications.java:375)
at
org.apache.giraph.comm.RPCCommunications.<init>(RPCCommunications.java:68)
at org.apache.giraph.graph.GraphMapper.map(GraphMapper.java:571)
at org.apache.hadoop.mapreduce.Mapper.run(Mapper.java:144)
at org.apache.hadoop.mapred.MapTask.runNewMapper(MapTask.java:763)
at org.apache.hadoop.mapred.MapTask.run(MapTask.java:369)
at
org.apache.hadoop.mapred.LocalJobRunner$Job.run(LocalJobRunner.java:210)
The issue is that with only a single worker, the ThreadpoolExecutor fails
because of having 0 threads as an argument.
This addresses bug GIRAPH-48.
https://issues.apache.org/jira /browse/GIRAPH-48
Diffs
-----
http://svn.apache.org/repos/asf/incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
1180785
Diff: https://reviews.apache.org/r/2322/diff
Testing
-------
Passed unittests.
Thanks,
Avery
> All tests failing under non-secure build
> ----------------------------------------
>
> Key: GIRAPH-48
> URL: https://issues.apache.org/jira/browse/GIRAPH-48
> Project: Giraph
> Issue Type: Bug
> Reporter: Jakob Homan
> Priority: Critical
>
> After GIRAPH-12, quite a lot of tests are failing when run under non-secure
> hadoop:
> {noformat}mvn -Dhadoop=non_secure clean test{noformat}
> results in:
> {noformat}Failed tests:
> testSuperstepBalancer(org.apache.giraph.TestVertexRangeBalancer)
> testBspCheckpoint(org.apache.giraph.TestManualCheckpoint)
> testBspSuperStep(org.apache.giraph.TestBspBasic)
> testBspMsg(org.apache.giraph.TestBspBasic)
> testBspCombiner(org.apache.giraph.TestBspBasic)
> testBspPageRank(org.apache.giraph.TestBspBasic)
> testBspShortestPaths(org.apache.giraph.TestBspBasic)
> testMutateGraph(org.apache.giraph.TestMutateGraphVertex)
> testContinue(org.apache.giraph.TestJsonBase64Format){noformat}
> rolling back to the previous commit, the tests pass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
